Viewport Addon #1740
Viewport Addon #1740
Conversation
…ngle button to switch.. unclear if that's good or not though.
# Conflicts: # lib/ui/package.json
Search box: make found options selectable with click
| } | ||
|
|
||
| componentDidMount() { | ||
| this.iframe = document.getElementById(storybookIframe); |
|
Really great addon! Thanks for doing this! I would add "write readme" to "Remaining Tasks". I didn't dig into a code yet but I wonder whether it will be compatible with upcoming multistory feature (#1394)? Although not sure that it should, just want to share this thought |
|
@saponifi3d @ndelangen I'd like to merge this into a feature branch in the storybook repo and add @saponifi3d to the storybooks org so we can more easily collaborate on fixing this up. OK? |
|
Welcome @saponifi3d ! 👍 |
|
Where is the git repo for this? Downloaded module from npm at https://www.npmjs.com/package/@storybook/addon-viewport -- all cool, but I have possible bugfix. |
|
@markoshust it's part of the storybook monorepo, if you go into https://github.com/storybooks/storybook/tree/release/3.3/addons/viewport Is the link, it's only part of the 3.3 feature branch |
|
@markoshust contact me on slack if you need help getting set up. There's also the CONTRIBUTING.md document. We're currently working off the release/3.3 branch as @saponifi3d mentioned. |
Description
This is a fairly early PR of a viewport plugin which allows you to resize the iframe of storybook.
Remaining Tasks
Possible Features
iframerather than just grabbing the iframe from the DOM add listeners to the iframe to allow us to interact with itScreen Cap
Issues
Fixes #1624