Angular: Retrieve version from core package #17363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI ran the following commands for commit 12e4b28. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
shilman
changed the title
shilman
changed the title
shilman
changed the title
shilman
approved these changes
Jan 29, 2022
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Jan 29, 2022
Angular: Retrieve version from core package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
I have a
nx v13.1.3monorepo and today I've tried to update@storybook/*from~6.3.0to~6.4.0and got an error:Solution
Looking at the mentioned file (
node_modules/@storybook/angular/dist/ts3.9/server/framework-preset-angular-cli.js)I see that it tries to extract the
VERSIONof the@angular/clipackage but my Nx monorepo doesn't have it.I also see that it's just an indication to use different files of
@angular-devkit/build-angularbut that package doesn't expose its version, so I got a successful build just extracting the version from@angular/coreinstead, which should be similar to the CLI in use :)