Core: Fix useParameter
with nullish coalescing
#17327
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The
useParameter(..)
hook accepts a key and a default value. It thenprovides the default value if the current story has not provided a
desired value for the relevant
parameters
object.What I did
This change updates the logic of when to fall back to the default. The
old logic used a boolean operator (
||
), which worked as long as theprovided value wasn't falsey. Instead, account for this by using the
nullish coalescing operator (
??
).How to test
Create an addon which consumes a parameter like:
Create a story which looks like:
Note that the value of
parameters
in your addon will always bethe default object, not
false
(as was requested by the story).If your answer is yes to any of these, please make sure to include it in your PR.