Core: Fix issue with recursive glob with prior special chars #17252
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #17038, #16964, #16924
In all three cases the issue is special glob patterns before the
**
in the glob.In 6.4, we incorrectly changed the condition for a recursive look up to be the
files
glob had to start with**
, which is broken in the above cases.What I did
This goes back to the old condition (recursive if the glob contains
'**'
or'/'
-- I suspect just the latter would be enough). Plus add a fix for our normalisation of directory names when they are just'..'
or'.'
How to test
See tests. You can also create a reproduction SB with one of the following
stories
fields: