-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular: Fix 13.1 and add CI test cases #17206
Conversation
☁️ Nx Cloud ReportCI ran the following commands for commit ad72f05. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
ccf3dc4
to
22fd49d
Compare
22fd49d
to
0c75b2a
Compare
0c75b2a
to
ad72f05
Compare
@@ -222,7 +222,7 @@ jobs: | |||
# Do not test CRA here because it's done in PnP part | |||
# TODO: Remove `web_components_typescript` as soon as Lit 2 stable is released | |||
# TODO: Add `angular` as soon as Storybook is compatible with Angular 13 | |||
command: yarn test:e2e-framework vue3 angular12 angular11 web_components_typescript web_components_lit2 | |||
command: yarn test:e2e-framework vue3 angular130 angular13 angular12 angular11 web_components_typescript web_components_lit2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can maybe remove the comment of L224, as angular13
== angular
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Merging this @ThibaudAV 🙏
I tried version
|
Angular: Fix 13.1 and add CI test cases
Issue: #17201 #16977
What I did
Add e2e for angular 13.0.x and for 13.x.x
Fix issue with 13.0
second error with bad tsConfig from legacy options fetch inside angular.json
And add
allowSyntheticDefaultImports: true
for angular generate to fix sb init for angular 13..x✏️ I really think that all this part could be remade for Angular 13 with .ts config files, a clean tsconfig and use the default angular builder
How to test
If your answer is yes to any of these, please make sure to include it in your PR.