Core: Retain iframe.html query parameters #17136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI ran the following commands for commit 5e1a286. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
shilman
requested changes
Jan 6, 2022
There was a problem hiding this comment.
Thanks @ittaibaratz ! The concept sounds reasonable, but the code has some weird dependencies. Would be great to fix that before merging.
Sure thing! That's done now, please check. |
shilman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Retain iframe.html query parameters coming from PREVIEW_URL
What I did
This is a follow up to my previous PR, #16773.
The previous PR allowed the docs add on to use a specific iframe source configured via PREVIEW_URL. However we realized that even with doing that, Storybook always overrides any pre-existing query parameters when it sets its own query parameters (id, viewMode, etc).
This PR adds a utility function (getStoryHref) that will add the storybook query params without removing the existing params in the process.
How to test
TBD
If your answer is yes to any of these, please make sure to include it in your PR.