-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Router: Fix navigating to hash links #17134
Conversation
☁️ Nx Cloud ReportCI ran the following commands for commit 1ab9ad9. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
I think this replaces this PR: |
@ndelangen I'm wondering what kind of test we can add so this broken behavior won't raise it's head in the future. |
@sag1v fair question, I don't have a good idea right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 @ndelangen 💯
Router: Fix navigating to hash links
Hash/anchor links still do not seem to work (version 6.4.18). |
What are you experiencing? Does it load a blank page or just doesn't do anything...? |
It loads the component into a new window without the storybook container. It's the iframe.html page version of the component that opens up. |
Are you able to reproduce it with a clean minimal project? |
Issue: #16918
What I did
How to test