-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular: Fix angular 13.1 JIT error and HMR reload #17131
Conversation
☁️ Nx Cloud ReportCI ran the following commands for commit abdcedd. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
d2674aa
to
90dda44
Compare
@@ -142,8 +147,12 @@ async function getLegacyDefaultBuildOptions(options: PresetOptions) { | |||
return {}; | |||
} | |||
|
|||
// TODO ~ legacy way to get default options | |||
// TODO ~ Add deprecation warning and ex for builder use ? `); | |||
logger.warn(dedent` Your Storybook startup uses a solution that will not be supported in version 7.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can improve my English 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ThibaudAV !!!! 🙏 🙏 🙏
It looks like this is breaking on the Angular12 e2e tests. Can you please take a look?
thanks will do more test with fresh install in Angular 12.x. (not only a CSF3 and IRL project) |
90dda44
to
facf541
Compare
facf541
to
abdcedd
Compare
fixed no ? There are now 2 distincts modes old and new. It was necessary to exclude this configuration with the same "reasoning"
there is this distinction for the builder and angular 12 because it allowed to validate the new way before angular 13. and I think it's good to keep it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ThibaudAV !!! 🙏 💯 🎖️
Angular: Fix angular 13.1 JIT error and HMR reload
Issue: #17039
What I did
How to test
Angular test by @ThibaudAV locally on project :
other ?
If your answer is yes to any of these, please make sure to include it in your PR.