Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Install lit-html in new web components project #17106

Merged
merged 1 commit into from Jan 3, 2022
Merged

CLI: Install lit-html in new web components project #17106

merged 1 commit into from Jan 3, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jan 2, 2022

Issue: #15851

What I did

Added lit-html as an extra package to be installed when generate a web components project.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Jan 2, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit 9c1a346. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@MichaelArestad MichaelArestad requested a review from shilman January 3, 2022 14:43
@MichaelArestad MichaelArestad removed the request for review from shilman January 3, 2022 14:44
@shilman shilman changed the title install lit-html in new web components project CLI: Install lit-html in new web components project Jan 3, 2022
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jacobia21, much appreciated! 🙏

@shilman shilman changed the title CLI: Install lit-html in new web components project CLI: Install lit-html in new web components project Jan 3, 2022
@shilman shilman merged commit 3fdb6ea into storybookjs:next Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants