Angular: Fix for renamed method in angular 13.1 #17032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI ran the following commands for commit 854e374. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
mandarini
force-pushed
the
fix/angular-131-method-rename
branch
from
edc925f to
854e374
Compare
shilman
changed the title
shilman
approved these changes
Dec 18, 2021
There was a problem hiding this comment.
Nice one @mandarini !! I like the simplicity of this one vs the previous PR.
@storybookjs/angular WDYT?
|
See this comment. As far as I know, removing the I do like the idea of using a ternary operator instead of a whole new config though. I think we might be able to also combine the configs for 12.2.x and 13.x since there is only a small difference between the two. |
shilman
added
patch:yes
shilman
added a commit
that referenced
this pull request
Jan 11, 2022
Angular: Fix for renamed method in angular 13.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #16977
Broken build when on Angular v.
13,1--> comment: #16977 (comment)
Quoting comment:
The problem is that in angular 13.1 the function
getTypescriptWorkerPluginchanged names togetDevServerConfigI was able to get it running by replacing all occurances of
getTypescriptWorkerPluginWhat I did
Renamed the method to the new name - it's a bit ugly because it's using a ternary to see if old one exists - if not use new one. More proper way would be to check Angular version from lock file I guess...
How to test
Storybook for Angular
13.1can now run without throwing the errorTypeError: getTypescriptWorkerPlugin is not a function.Disclaimer
I am not sure if we would need to add an extra check of the Angular version that's actually installed..