Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set string to string[] when is not necessary in jest addon documentation #17009

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

silversonicaxel
Copy link
Contributor

Set to string when string[] is not necessary

Issue:

What I did

Improved documentation

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Dec 13, 2021

☁️ Nx Cloud Report

CI ran the following commands for commit 20665e1. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@silversonicaxel
Copy link
Contributor Author

as @kylegach suggested here #16965 (comment) , I recreated my PR due to some previous conflicts.

Copy link
Contributor

@kylegach kylegach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good!

@kylegach kylegach added addon: jest documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Dec 14, 2021
@MichaelArestad MichaelArestad merged commit 562cb07 into storybookjs:next Dec 20, 2021
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Dec 27, 2021
shilman pushed a commit that referenced this pull request Dec 27, 2021
Set `string` to `string[]` when  is not necessary in jest addon documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: jest documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants