Core: Ensure that context.args is always set
#16790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nx Cloud ReportCI ran the following commands for commit 35d0096. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
shilman
changed the title
context.args is always set.context.args is always set
shilman
reviewed
Nov 26, 2021
| hooks: new HooksContext(), | ||
| ...firstStory, | ||
| } as any); | ||
| expect(renderMock).toHaveBeenCalledWith({}, expect.objectContaining({ argsByTarget: {} })); |
There was a problem hiding this comment.
@tmeasday shouldn't this be asserting something about args? and same for above?
There was a problem hiding this comment.
Args is the first argument ({})
This was referenced Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #16743
What I did
Ensure we don't filter all args down to nothing.
How to test
Yes see tests