Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add require line for TsconfigPathsPlugin #16770

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Conversation

mann-david
Copy link
Contributor

you also need const TsconfigPathsPlugin = require('tsconfig-paths-webpack-plugin'); in main.js. Obvious, perhaps, but it could save someone a step if they miss it (like I did :-) )

Issue:

What I did

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

you also need const TsconfigPathsPlugin = require('tsconfig-paths-webpack-plugin'); in main.js. Obvious, perhaps, but it could save someone a step if they miss it (like I did :-) )
@nx-cloud
Copy link

nx-cloud bot commented Nov 23, 2021

Nx Cloud Report

CI ran the following commands for commit 8a79e81. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@MichaelArestad MichaelArestad added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Nov 29, 2021
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman merged commit 43e5940 into storybookjs:next Nov 29, 2021
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Nov 30, 2021
shilman added a commit that referenced this pull request Nov 30, 2021
Add require line for TsconfigPathsPlugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants