Update peer dependencies for angular 13 support #16758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rxjs 7 (angular 13) - build-angular version range change from angular 12
- update yarn.lock
Nx Cloud ReportCI ran the following commands for commit 5ec9ca1. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
shilman
approved these changes
Nov 22, 2021
There was a problem hiding this comment.
Thanks @SnakeSVx !!! 🙏
@literalpie per your comment on the issue, it looks like the CI is not failing any worse than it was before. since peer dependencies should "accept" whatever the user has already installed in their app/library i suspect that this is a safe change and am inclined to merge. but let me know if you think it's a bad idea!! 🙏
|
I don't think there's any reason not to merge this. Worst case scenario is that it only partially fixes the issue :-) |
kroeder
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #16749
What I did
Update peer dependencies to support current angular versions 12/13.
How to test
If your answer is yes to any of these, please make sure to include it in your PR.