Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Add eslint-plugin-storybook to the repo #16662

Merged
merged 21 commits into from
Nov 11, 2021
Merged

Build: Add eslint-plugin-storybook to the repo #16662

merged 21 commits into from
Nov 11, 2021

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Nov 10, 2021

Issue: N/A

What I did

This applies the eslint-plugin-storybook to the monorepo, as well as fixes for all of its recommended rules.

There are quite a few changes. I added some @TODO for discussions.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@yannbf yannbf added the maintenance User-facing maintenance tasks label Nov 10, 2021
@yannbf yannbf requested a review from shilman November 10, 2021 17:54
@nx-cloud
Copy link

nx-cloud bot commented Nov 10, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit 92294f5. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

shilman
shilman approved these changes Nov 11, 2021
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @yannbf 💯

@shilman shilman changed the title Add eslint-plugin-storybook to the repo Build: Add eslint-plugin-storybook to the repo Nov 11, 2021
@shilman shilman added this to the 6.4 PRs milestone Nov 11, 2021
@shilman shilman merged commit ddcf10a into next Nov 11, 2021
@shilman shilman deleted the feature/eslint-plugin-test branch November 11, 2021 17:25
@lili2311 lili2311 mentioned this pull request Nov 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylegach kylegach kylegach left review comments

@tmeasday tmeasday tmeasday left review comments

@shilman shilman shilman approved these changes

Assignees
No one assigned
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
6.4 PRs
Development

Successfully merging this pull request may close these issues.
4 participants
@yannbf @tmeasday @kylegach @shilman