Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add qs as a dev dependency of the api package #16525

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

stof
Copy link
Contributor

@stof stof commented Oct 29, 2021

Issue:

What I did

qs is used in the testsuite of the api package. #16440 removed qs from dependencies, but without adding it in devDependencies (the CI works thanks to the hoisting of qs from a transitive dependency).

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@stof stof mentioned this pull request Oct 29, 2021
3 tasks
@nx-cloud
Copy link

nx-cloud bot commented Oct 29, 2021

Nx Cloud Report

We didn't find any information for the current pull request with the commit 2548c38.
You might need to set the 'NX_BRANCH' environment variable in your CI pipeline.

Check the Nx Cloud Github Integration documentation for more information.


Sent with 💌 from NxCloud.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @stof !!!! 🙏

@shilman shilman merged commit f521a74 into storybookjs:next Oct 29, 2021
@stof stof deleted the fix_qs_deps branch October 31, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants