Core: Always update initial args when loading a story #16487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And also update the current args with the delta. This means both when we change story (to an HMR-ed story) and when we HMR the current story.
Nx Cloud ReportCI ran the following commands for commit 1564b2c. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
yannbf
reviewed
Oct 27, 2021
shilman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #16486
And also update the current args with the delta. This means both when we change story (to an HMR-ed story) and when we HMR the current story.
What I did
Instead of updating args only when the current story's implementation changes, instead always "update" the args when we load a story, if the
initialArgshave changed.How to test
button.stories.tsinreact-tsStoryNoRender) in the editor, wait for HMR.Also try different combinations, e.g. if you visit the changing story first (before switching away) or if you only ever visit the other story.