-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Ensure we don't reset WebPreview
if calling start()
in v7 mode
#16475
Conversation
Nx Cloud ReportCI ran the following commands for commit 894fd20. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I'm missing how this is connected to the bug.
- I don't see any imports from
@storybook/angular
in his code - Is this the line that's ultimately failing?
https://github.com/storybookjs/storybook/blob/next/addons/a11y/src/a11yRunner.ts#L72
Yeah, correct. The second story store that is created is never initialized (as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification @tmeasday. Fixed a couple bugs with the API signature 😉
WebPreview
if calling start()
in v7 modeWebPreview
if calling start()
in v7 mode
Issue: #16455
The problem was that when you import from
@storybook/angular
it callsstart()
(as do all other frameworks), which created an old, non-v7StoryStore
and assigned it to__STORYBOOK_STORY_STORE__
, then awaited aconfigure()
call (that never came....)What I did
start()
is a no-op in v7 modeQuestions
Should we make some of that API work (i.e.
api.raw()
etc?)How to test
See example in issue.