Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactions: Use latest package versions #16464

Merged
merged 3 commits into from
Oct 25, 2021
Merged

Conversation

ghengeveld
Copy link
Member

Issue: #16422

What I did

Used the latest package versions for @storybook/jest and @storybook/testing-library, the former of which fixes the issue with static expect methods getting intercepted.

How to test

  • Is this testable with Jest or Chromatic screenshots? no
  • Does this need a new example in the kitchen sink apps? no
  • Does this need an update to the documentation? no

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Oct 23, 2021

Nx Cloud Report

CI ran the following commands for commit 8123b37. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@ghengeveld ghengeveld changed the title Use latest package versions Interactions: Use latest package versions Oct 23, 2021
@ghengeveld
Copy link
Member Author

The failing E2E tests seem unrelated.

@yannbf
Copy link
Member

yannbf commented Oct 25, 2021

Nice stuff @ghengeveld! I tested it out and the problem is gone, however in the waitFor story, stepping through it instantly throws an error in preview:

image

Steps:
1 - Select waitFor example
2 - Click on "Go back" in the panel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants