Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Restore queryparams exports in client-api #16414

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Core: Restore queryparams exports in client-api #16414

merged 1 commit into from
Oct 20, 2021

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Oct 20, 2021 •
edited by shilman
Loading

Issue: #16411

What I did

Restored the file queryparams.ts in client-api.

How to test

Try it with knobs

@tmeasday tmeasday requested a review from shilman October 20, 2021 08:17
@nx-cloud
Copy link

nx-cloud bot commented Oct 20, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit 4511c90. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@shilman shilman added this to the 6.4 PRs milestone Oct 20, 2021
@shilman shilman changed the title Restore queryparams exports from client-api Core: Restore queryparams exports in client-api Oct 20, 2021
shilman
shilman approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tmeasday

@shilman shilman merged commit a6e810b into next Oct 20, 2021
@shilman shilman deleted the 16411-restore-getQueryParams branch October 20, 2021 08:38
@shilman shilman mentioned this pull request Oct 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees
No one assigned
Labels
bug core preview-api
Projects
None yet
Milestone
6.4 PRs
Development

Successfully merging this pull request may close these issues.
2 participants
@tmeasday @shilman