Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Update mono font stack #16409

Merged
merged 2 commits into from
Oct 21, 2021
Merged

UI: Update mono font stack #16409

merged 2 commits into from
Oct 21, 2021

Conversation

MichaelArestad
Copy link
Contributor

@MichaelArestad MichaelArestad commented Oct 19, 2021

Issue: #16278

What I did

  1. I updated the monospace font stack to be a little more consistent across browsers and operating systems.
  2. I updated the Basics/Typography story to better represent the typefaces.

TODO

I would like to update the story for Storybook's typography to use the Typeset docblock, but I wasn't able to do it myself. I could use an assist from @yannbf or @kylegach if either of you have some time to spare over the next few days.

Update: Thanks, Kyle G. for the assist

How to test

  1. Open up Storybook Official via the link below
  2. Try out the Actions addon or the Interactions addon to see examples of components using the monospace font.

Before

image

image

After

image

image


  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

@nx-cloud
Copy link

nx-cloud bot commented Oct 19, 2021

Nx Cloud Report

CI ran the following commands for commit f138ed6. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@MichaelArestad MichaelArestad added the maintenance User-facing maintenance tasks label Oct 19, 2021
@shilman shilman modified the milestones: 6.4 improvements, 6.4 PRs Oct 20, 2021
Copy link
Member

@domyen domyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the attention to detail

@shilman shilman changed the title Update mono stack UI: Update mono font stack Oct 21, 2021
@shilman shilman merged commit 05b93be into next Oct 21, 2021
@shilman shilman deleted the update-mono-font-stack branch October 21, 2021 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks theming ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants