Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Update sidebar hover color to be a refreshing transparent blue #16408

Merged
merged 1 commit into from
Oct 21, 2021

Conversation

MichaelArestad
Copy link
Contributor

What I did

In a discussion with @dom, we decided to update the sidebar item hover color to the same blue we used as a hover state in the Interactions addon. I updated theme.background.hoverable to use a transparent blue that place really nicely in both light and dark contexts.

How to test

  1. Open up the Official Storybook linked below.
  2. Navigate to UI > Sidebar > Sidebar > Simple
  3. Try out the new hover color
  4. Switch to the dark theme and make sure it works there

Other places to test:

  • The Storybook search results
  • The accessibility addon uses this color, but doesn't have stories for its own components.
  • Addons > Interactions > Interaction
  • Addons > Interactions > Subnav (the buttons)
  • Jest > open a story > open the Tests panel

Before

image
image
image
image

After

image
image
image
image

@nx-cloud
Copy link

nx-cloud bot commented Oct 19, 2021

Nx Cloud Report

CI ran the following commands for commit 5ed4eff. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@MichaelArestad MichaelArestad self-assigned this Oct 19, 2021
@shilman shilman added maintenance User-facing maintenance tasks and removed other labels Oct 20, 2021
@shilman shilman changed the title Update sidebar hover color to be a refreshing transparent blue UI: Update sidebar hover color to be a refreshing transparent blue Oct 20, 2021
@shilman shilman modified the milestones: 6.4 improvements, 6.4 PRs Oct 20, 2021
@yannbf
Copy link
Member

yannbf commented Oct 20, 2021

Nice work @MichaelArestad !!

Did you also take into account the color used when navigating the sidebar via keyboard?

Here's a comparison of the changes including the hover states and the highlight with keyboard navigation, also the difference in the jest/a11y addon:
image

@MichaelArestad
Copy link
Contributor Author

@yannbf I did not. Good catch! I think they are different it enough it still works well. In the future I might align the colors and add an outline to keyboard focus states.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great -- love the new look! 😍

@shilman shilman merged commit 31e3220 into next Oct 21, 2021
@shilman shilman deleted the update-color-hoverable branch October 21, 2021 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants