Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update react-element-to-jsx-string package #16407

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Update react-element-to-jsx-string package #16407

merged 1 commit into from
Oct 20, 2021

Conversation

Andarist
Copy link
Contributor

closes #12747

@Andarist Andarist requested a review from ndelangen October 19, 2021 16:49
@nx-cloud
Copy link

nx-cloud bot commented Oct 19, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit 0931c15. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@shilman shilman added dependencies patch:yes Bugfix & documentation PR that need to be picked to main branch labels Oct 20, 2021
shilman
shilman approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Andarist, both for the update and also for improving react-element-to-jsx-string!

@shilman shilman added this to the 6.4 PRs milestone Oct 20, 2021
@shilman shilman merged commit 59059f9 into next Oct 20, 2021
@shilman shilman deleted the update-react-element-to-jsx-string branch October 20, 2021 03:30
@shilman shilman mentioned this pull request Oct 20, 2021
Closed
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Nov 27, 2021
@angry-meow angry-meow mentioned this pull request Dec 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@ndelangen ndelangen Awaiting requested review from ndelangen

Assignees
No one assigned
Labels
dependencies patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
6.4 PRs
Development

Successfully merging this pull request may close these issues.

Circular references in React prop data causes stack overflow error in v6
2 participants
@Andarist @shilman