Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-a11y: Fix to use loadStory over deprecated fromId #16398

Merged
merged 6 commits into from
Oct 20, 2021
Merged

Conversation

tmeasday
Copy link
Member

Issue: #16353

What I did

Use async loadStory(), rather than deprecated fromId()

How to test

  • Is this testable with Jest or Chromatic screenshots?

We could add an e2e test?

  • Does this need a new example in the kitchen sink apps?

I restored addon-a11y to a couple of examples

@nx-cloud
Copy link

nx-cloud bot commented Oct 19, 2021

Nx Cloud Report

CI ran the following commands for commit 8edf6a6. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@tmeasday
Copy link
Member Author

I accidentally pushed a commit from this branch to next, thus the revert madness

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @tmeasday what implications does this have for our broader addon ecosystem, if any? do we need to write a migration guide for addon authors?

addons/a11y/src/a11yRunner.ts Outdated Show resolved Hide resolved
@tmeasday
Copy link
Member Author

LGTM. @tmeasday what implications does this have for our broader addon ecosystem, if any? do we need to write a migration guide for addon authors?

I'm not sure how common it is for addon authors to be using internal store APIs like fromId() or raw()/extract(). I can add some migration notes about it I guess?

@shilman shilman changed the title Fix addon-a11y to use loadStory Addon-a11y: Fix to use loadStory over deprecated fromId Oct 20, 2021
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 💯

@shilman shilman merged commit c15ac11 into next Oct 20, 2021
@shilman shilman deleted the 16353-fix-a11y-v7 branch October 20, 2021 08:41
@shilman shilman added this to the 6.4 PRs milestone Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants