-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon-a11y: Fix to use loadStory
over deprecated fromId
#16398
Conversation
Nx Cloud ReportCI ran the following commands for commit 8edf6a6. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
I accidentally pushed a commit from this branch to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @tmeasday what implications does this have for our broader addon ecosystem, if any? do we need to write a migration guide for addon authors?
Co-authored-by: Michael Shilman <[email protected]>
I'm not sure how common it is for addon authors to be using internal store APIs like |
addon-a11y
to use loadStory
loadStory
over deprecated fromId
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one 💯
Issue: #16353
What I did
Use async
loadStory()
, rather than deprecatedfromId()
How to test
We could add an e2e test?
I restored
addon-a11y
to a couple of examples