-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Fix scrollbar color to be visible in dark theme #16345
Conversation
Nx Cloud ReportCI ran the following commands for commit af9b9ef. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
Nice! I love it 😻
…On Wed, Oct 13, 2021 at 3:13 PM nx-cloud[bot] ***@***.***> wrote:
Nx Cloud Report
We didn't find any information for the current pull request with the
commit c6c9120
<c6c9120>
.
You might need to set the 'NX_BRANCH' environment variable in your CI
pipeline.
Check the Nx Cloud Github Integration documentation
<https://nx.app/docs/public-cloud-github-integration> for more
information.
------------------------------
Sent with 💌 from NxCloud. <https://nx.app>
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#16345 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACAJWL3YXJYYQOMKQITG3DUGYABNANCNFSM5F6HOEXQ>
.
|
Super awesome seeing your contributions @MichaelArestad! I'm wondering if the color will be set for other scenarios as well like here |
You know, I'm not sure what's going on there, @yannbf. I am not entirely clear what |
I will try this out right now and get back to you! |
Alright I just got confused! LGTM!! |
Thanks, @yannbf ! |
@yannbf pointed out to me the scrollbar handles are nearly invisible when using the dark theme. Let's fix that!
What I did
I modified the color to work well in both dark and light themes. I looked at the MacOS scrollbars in both MacOS dark/light modes to roughly match the contrast in both modes. It is also trivial to make each mode have a different color (that's what I did at first), but I think this works well alongside the MacOS scrollbar handles.
How to test
examples/official-storybook/manager.js
to enable dark mode.Before
After