Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: silence unexpected control type enum for color matchers #16334

Merged
merged 4 commits into from
Jul 1, 2022
Merged

bug: silence unexpected control type enum for color matchers #16334

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b29e131
fix: silence unexpected control type enum for color matchers
Oct 13, 2021
6ac9e00
Merge branch 'next' into fix/silence-unexpected-color-warning/16322
ndelangen Jun 30, 2022
cac26cc
Update lib/store/src/inferControls.ts
ndelangen Jun 30, 2022
dac12e5
Update lib/store/src/inferControls.ts
ndelangen Jun 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lib/store/src/inferControls.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,12 @@ const inferControl = (argType: StrictInputType, name: string, matchers: Controls
return { control: { type: 'color' } };
}

logger.warn(
`Addon controls: Control of type color only supports string, received "${controlType}" instead`
);
*/
ndelangen marked this conversation as resolved.
Show resolved Hide resolved
if (controlType !== 'enum') {
logger.warn(
`Addon controls: Control of type color only supports string, received "${controlType}" instead`
);
}
}

// args that end with date e.g. purchaseDate
Expand Down