Upgrade boxen to 5.x #16190
Merged
Upgrade boxen to 5.x #16190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The breaking change in this major version is dropping support for node <10, and storybook already requires node 10+. This removes one path depending on outdated versions of ansi-regex that are vulnerable for ReDoS.
Nx Cloud ReportCI ran the following commands for commit 247f481. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
shilman
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
boxenis upgraded from 4.x to 5.x.The breaking change in this major version is dropping support for node <10, and storybook already requires node 10+.
This removes one path depending on outdated versions of
ansi-regexthat are vulnerable for ReDoS (the dependency tree ofnpmlogstill includes it though).How to test
If your answer is yes to any of these, please make sure to include it in your PR.