-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tree view visual adjustments #1599
Conversation
Link color from Welcome story was used to indicate that story menu items are proper links |
The blue/underlined links both seem a little too intense to me. I think sidebar navigation is a common enough UI pattern that making the links stand out that much is unnecessary. If anything, maybe a slightly lighter font color for story links? Or perhaps kinds could be bold, and story links normal weight? Something more along the lines of this, perhaps? |
@igor-dv did you mean to close this? |
Codecov Report
@@ Coverage Diff @@
## master #1599 +/- ##
==========================================
+ Coverage 21.32% 21.34% +0.01%
==========================================
Files 244 244
Lines 5378 5378
Branches 662 652 -10
==========================================
+ Hits 1147 1148 +1
- Misses 3725 3745 +20
+ Partials 506 485 -21
Continue to review full report at Codecov.
|
Yeah, the dark grey story links looks much better IMO. |
Just for the record, the current branch state contains all the upvoted changes, without the downvoted ones =) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the look and feel of something existing is always gonna be controversial. I'm pretty comfortable with the changes here, think this would add clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good: ✅
Locally tested: ❌
Anyone opposed to merging this? ( @shilman ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
See discussion in #1523
This PR consists of several changes, which can be applied quite independently. I'll describe each of them in a separate comment, so that you can vote with emoji reactions.