UI: Fix ActionButton out of position in Safari #15981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nx Cloud ReportCI ran the following commands for commit 2770bfa. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
eungyeole
changed the title
eungyeole
changed the title
darleendenno
approved these changes
Sep 7, 2021
There was a problem hiding this comment.
Hey @eungyeole 👋 Thanks for filing this bug and fixing it yourself! ❤️ ❤️
@shilman this is good to go. Confirmed issue on Safari, and confirmed this fix works on reported browsers and versions 👍
shilman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #15974
What I did
As you can see on the issue, ActionButton is out of position in Safari.
So I added 'margin: 0'.
How to test
If your answer is yes to any of these, please make sure to include it in your PR.