TypeScript: Fix glob pattern used in package typesVersions config
#15918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nx Cloud ReportCI ran the following commands for commit 6f45ba1. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
ndelangen
approved these changes
Aug 30, 2021
shilman
changed the title
typesVersions configtypesVersions config
shilman
changed the title
typesVersions configtypesVersions config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #15196
What I did
I updated the glob pattern used in
typesVersionsfield of all thepackage.jsonbecause it looks like the previous one wasn't working. See the issue for details, I was able to reproduce with Angular 9, TS 3.6 and SB 6.3.How to test
@storybook/angularpackage in your node_modules with the change done in the PR should fix the pb.