fix(build): avoid logging an object on compilation errors

[BlackHole1]

When building with webpack, all information from stats will be printed when an error occurs.

In my project, stats will print out over 5,000 lines, which is hard to swallow..

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8b4f8ee. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 1 target

• nx run-many --target=prepare --all --parallel=2 --max-parallel=15 -- --optimized

---

Sent with 💌 from NxCloud.

[stale]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

[ndelangen]

Hello @BlackHole1 really appreciate the assist here, could you show us the error occurring somewhere perhaps?
Does it happen in one of the examples in this monorepo?

[BlackHole1]

Hello @BlackHole1 really appreciate the assist here, could you show us the error occurring somewhere perhaps? Does it happen in one of the examples in this monorepo?

yes, the project uses monorepo.

[BlackHole1]

see: https://github.com/netless-io/flat/runs/4975672133?check_suite_focus=true#step:7:380

[ndelangen]

I think the true reason we're logging this stat is because of this: (we are throwing here with the stats

storybook/lib/builder-webpack4/src/index.ts

Line 149 in 89830ad

return fail(stats);

and then this: (we are awaiting these 2 promises (the preview is throwing)

storybook/lib/core-server/src/build-static.ts

Line 146 in 89830ad

const [managerStats, previewStats] = await Promise.all([manager, preview]);

and then finally the thrown stats object is caught here, and logged as an error:

storybook/lib/core-server/src/build-static.ts

Line 173 in 89830ad

logger.error(e);

I think we should throw with a generic error instead here:

storybook/lib/builder-webpack4/src/index.ts

Line 149 in 89830ad

return fail(stats);

          return fail(new Error('compiler encountered errors builder the preview'));

@BlackHole1 could you adjust the PR?
mind we have a similar code path in the builder-webpack5:

storybook/lib/builder-webpack5/src/index.ts

Lines 137 to 140 in 89830ad

	compiler.close(() =>
	options.debugWebpack
	? fail(stats)
	: fail(new Error('=> Webpack failed, learn more with --debug-webpack'))

and also for the manager builders:

storybook/lib/manager-webpack5/src/index.ts

Line 164 in 89830ad

fail(error || stats);

storybook/lib/manager-webpack4/src/index.ts

Line 166 in 89830ad

fail(error || stats);

[BlackHole1]

@ndelangen Great! I will be making adjustments later today.

[ndelangen]

@yannbf this seems relevant for our changes we were making today