-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSF3: Normalize windows paths in autoTitle #15770
CSF3: Normalize windows paths in autoTitle #15770
Conversation
Nx Cloud ReportCI ran the following commands for commit 98f5aa0. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
8647675
to
8b98db3
Compare
@yngvebn there's some problem with IE in this PR. is that something you can debug? cc @ndelangen @tooppaaa https://www.chromatic.com/build?appId=5def62c97bd45f0020ef370e&number=9053 |
Let me have a look |
A recap from discussions on Discord: I've added a tiny package (https://www.npmjs.com/package/slash) for normalizing paths. At first I added the most recent version (4). This was a pure ESM module, and all the jest tests failed with ESM related errors. Upgrading to an older version made those errors go away, but now there seems to be problems with the bundling of this module: So, I couldn't understand why this was happening on my branch... Seems the IE problem is not only on my branch... I checked a couple of the other netlify urls from different PRs, and they all fail with the same errors... :/
so, on the latter, IE is obviously kicking it on the path => arrow function |
b7f8b32
to
bb0891d
Compare
@tooppaaa is the addon-ie11 the reason for the failing IE11 stories? |
I'll have a look. |
Looks like IE 11 is back on track. I'm not sure about the failing unit test though |
Thank you! :D |
Issue:
What I did
In order for autoTitle to work on windows, the paths needs to be normalized into unix-style paths
How to test
If your answer is yes to any of these, please make sure to include it in your PR.