-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(documentation) add typescript.md for main.ts #15629
Conversation
You need ts-node to make the configuration file .ts. I have spent a lot of time trying to figure this out. Therefore, I would like to add this change to the documentation.
Nx Cloud ReportCI ran the following commands for commit b136ab8. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
And also, |
@tyankatsu0105 thanks for the context on this and help with it. I'm good with the suggestion if @purp1eeeee is willing to make it. Let me know once it's up and we'll go from there. Stay safe both of you. |
I'm not sure this is right. I just updated the react-ts example in the repo (#15621) and it works fine without ts-node, you just need to add a babelrc with typescript preset. I guess both are viable solutions. |
Yes @graup that sounds like a better solution to me 💯 |
@graup didn't know that it was already addressed by your pull request. @purp1eeeee if you could adjust accordingly we'd appreciate it. Let me know and we'll go from there. |
@purp1eeeee are you ok with adjusting this pull request based on the feedback? Let me know and we'll go from there. Sounds good? Stay safe |
@purp1eeeee just a friendly reminder if you're still able to follow up on the feedback and adjust your pull request so that we can look at it and hopefully merge it soon. Let me know and we'll go from there. Looking forward to the updates. Stay safe |
@jonniebigodes |
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
@purp1eeeee appreciate the time and effort you've put into this pull request and help us improve our documentation. We've just merged #17358 improving the documentation in this regard. With that, I hope you don't mind, but I'm going to close this pr now as it's now a bit outdated. Also, @graup appreciate the input and help in this one 🙏 ! Hope both of you have a fantastic weekend! Stay safe |
What I did
I need ts-node to make the configuration file
.ts
. I have spent a lot of time trying to figure this out. Therefore, I would like to add this change to the documentation.