Use ReactModal for search box #1548
Merged
+195
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1548 +/- ##
=========================================
Coverage ? 20.88%
=========================================
Files ? 241
Lines ? 5258
Branches ? 648
=========================================
Hits ? 1098
Misses ? 3660
Partials ? 500
Continue to review full report at Codecov.
|
Hypnosphi
commented
Jul 31, 2017
| // remove current focus on opening to prevent firing 'enter' keyDowns on it when modal closes | ||
| if (this.props.showSearchBox && !prevProps.showSearchBox && document.activeElement) { | ||
| document.activeElement.blur(); | ||
| } |
There was a problem hiding this comment.
This can be removed if and when reactjs/react-modal#464 resolves
There was a problem hiding this comment.
Good intel - might be worth dropping that in here as a comment?
|
Thanks, this looks really good! I want to test it locally before I'll merge. NOT TO SELF: I should really setup automatic example deployment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #871
What I did
Wrapped search box in ReactModal
How to test
Open search with
⌘ ⇧ P. Close it with Esc key or a click outside of the box