Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSF: Fix auto-title generation for standard config dir #15430

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

shilman
Copy link
Member

@shilman shilman commented Jun 30, 2021

Issue: N/A

What I did

The previous auto-title PR #15376 failed for a typical Storybook setup in which the configDir is different from the current working directory. I didn't catch it because my test case was examples/react-ts which is a corner case where the configDir IS the current directory.

To address this:

  • Added logic to rewrite the directory specifier to match webpack's fileName
  • Added a unit test
  • Added a new example, examples/cra-ts-kitchen-sink, which uses the typical config structure

self-merging @tmeasday

How to test

See attached tests

@nx-cloud
Copy link

nx-cloud bot commented Jun 30, 2021

Nx Cloud Report

CI ran the following commands for commit 957d634. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@shilman shilman merged commit 09af5e4 into next Jun 30, 2021
@shilman shilman deleted the fix/auto-title-generation branch June 30, 2021 07:16
@shilman shilman added this to the 6.4 PRs milestone Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant