Core: Fix decorator context update #15408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As each decorator runs, we need to keep updating the "context store" to include the partial update that potentially was passed.
Nx Cloud ReportCI ran the following commands for commit 66b12b8. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
tmeasday
added
bug
core
patch:yes
shilman
changed the title
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Jun 29, 2021
Core: Fix decorator context update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #15400
Previously we always passed the combination of the original context and the previous decorator's passed arguments into the next decorator.
That meant if an earlier decorator set something on the context, it would get lost by the time it reached the story.
What I did
Updated the "decorator with context store" so that the context store keeps getting updated after each decorator along the chain.
How to test
PR includes a jest test and a story that demonstrate the behaviour