Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update addon measure to fix hooks related issue #15167

Merged
merged 1 commit into from
Jun 8, 2021
Merged

Conversation

winkerVSbecks
Copy link
Contributor

Issue:

What I did

Updated addon-measure with fix for hook related issue [closes #15151]

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@winkerVSbecks winkerVSbecks requested a review from shilman June 7, 2021 19:09
@nx-cloud
Copy link

nx-cloud bot commented Jun 7, 2021

Nx Cloud Report

CI ran the following commands for commit 1108d65. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman merged commit bac4ac1 into next Jun 8, 2021
@shilman shilman deleted the fix-addon-measure branch June 8, 2021 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Essentials: Measure addon breaks hooks
2 participants