Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Fix prebuilt manager #15050

Merged
merged 3 commits into from
May 26, 2021
Merged

Core: Fix prebuilt manager #15050

merged 3 commits into from
May 26, 2021

Conversation

ghengeveld
Copy link
Member

Issue: #13200

What I did

Fix prebuilt manager for webpack4 and webpack5.

How to test

  • Is this testable with Jest or Chromatic screenshots? no
  • Does this need a new example in the kitchen sink apps? updated cra-ts-essentials
  • Does this need an update to the documentation? no

If your answer is yes to any of these, please make sure to include it in your PR.

@ghengeveld ghengeveld requested a review from shilman May 26, 2021 10:14
@nx-cloud
Copy link

nx-cloud bot commented May 26, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit a0f7e28. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

shilman
shilman approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! 🚀

@ghengeveld ghengeveld merged commit ac522bb into next May 26, 2021
@ghengeveld ghengeveld deleted the fix-prebuilt-manager branch May 26, 2021 10:55
@shilman shilman mentioned this pull request May 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@igor-dv igor-dv Awaiting requested review from igor-dv

@ndelangen ndelangen Awaiting requested review from ndelangen

Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghengeveld @shilman