-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move addon-info
into addons panel
#1501
Closed
Closed
Changes from 40 commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
53e10dc
Init Info Panel
usulpro 1920cf4
Add react-komposer to Addon-Info
usulpro 3eabb5d
Add decoratorInfo to Addon-Info
usulpro b003486
Merge branch 'release/3.3' into addon-info-to-panel
ndelangen ff4776c
Disable precommit
usulpro 82632db
Merge branch 'master' into addon-info-to-panel
usulpro 1c3d9a2
Restore after merging
usulpro 9137eee
Refactoring addon options
usulpro 5fe8b85
Change styles
usulpro 9b3f2c5
Fix panel behavior
usulpro e3ff456
Rename options.info (options.text) to summary
usulpro 5d7c2d2
Add JSX example
usulpro a494903
Addon Info package clean-up
usulpro a21ee5a
Add support of React Element in a single argument
usulpro e956ae8
Revert "Disable precommit"
usulpro fbf0406
Merge branch 'master' into addon-info-to-panel
usulpro fc6a11e
Update snapshots
usulpro 4384397
Fix marksy config
usulpro 0e77b8a
[WIP] Add storybook
usulpro eda4bfc
Merge branch 'master' into addon-info-to-panel
usulpro 79719c2
Setup Storybook
usulpro 470797f
Add marksy examples to Storybook
usulpro 8a8460c
Switch to remark markdown compiler
usulpro 01ea321
Temporary remove remark-github
usulpro 63e3026
Setup remark compiler
usulpro 33efb58
Adjust Pre component
usulpro 6404f20
Merge branch 'swith-to-remark' into addon-info-to-panel
usulpro bd33a63
Merge branch 'master' into addon-info-to-panel
usulpro 68f73c3
WIP
usulpro e8c6db4
Enable remark-github plugin
usulpro 5407663
Merge branch 'master' into addon-info-to-panel
usulpro edc04fe
Fix linting
usulpro 378067b
Merge branch 'master' into addon-info-to-panel
Hypnosphi 6e90ede
Fix
usulpro 800d014
Do not do date('Label', new Date()) in cra-kitchen-sink
usulpro 51e67d7
Fix tests
usulpro a9e4b4b
Remove obsolete comment
usulpro 9f89bc4
Merge branch 'release/3.3' into addon-info-to-panel
usulpro 01c6b2a
Short clean-up
usulpro 49e5414
Remove remark-github again
usulpro 5a47cb5
Merge branch 'release/3.3' into addon-info-to-panel
ndelangen c8a9d0f
Merge remote-tracking branch 'origin/addon-info-to-panel' into addon-…
usulpro 7a2812a
Revert "Remove remark-github again"
usulpro 079bae9
Get rid of remark plagins
usulpro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,5 @@ | ||
import '@storybook/addon-info/register'; | ||
import '@storybook/addon-knobs/register'; | ||
import '@storybook/addon-actions/register'; | ||
import '@storybook/addon-links/register'; | ||
import '@storybook/addon-options/register'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,22 @@ | ||
import React from 'react'; | ||
import { configure, setAddon, addDecorator } from '@storybook/react'; | ||
import InfoAddon from '../src/'; | ||
import { configure, setAddon } from '@storybook/react'; | ||
import { withInfo, setInfoOptions } from '@storybook/addon-info'; | ||
import { setOptions } from '@storybook/addon-options'; | ||
|
||
addDecorator((story) => ( | ||
<div style={{padding: 20}}> | ||
{story()} | ||
</div> | ||
)); | ||
setOptions({ | ||
downPanelInRight: true, | ||
}) | ||
|
||
setAddon(InfoAddon); | ||
setAddon({ | ||
summary(info) { | ||
return this.addDecorator(story => { | ||
setInfoOptions(info); | ||
return story(); | ||
}) | ||
} | ||
}); | ||
|
||
configure(function () { | ||
require('../example/story'); | ||
}, module); | ||
function loadStories() { | ||
require('../src/components/stories'); | ||
} | ||
|
||
configure(loadStories, module); |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Binary file not shown.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please let's concentrate to make cra-kitchen-sink THE place where we all add working examples.
Adding a dev-setup to all packages is just going to get so hard to manage over time.
Do you agree?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, see my comment below