Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Add sb link --local option #14950

Merged
merged 1 commit into from
May 20, 2021
Merged

CLI: Add sb link --local option #14950

merged 1 commit into from
May 20, 2021

Conversation

shilman
Copy link
Member

@shilman shilman commented May 16, 2021

Issue: N/A

What I did

Allow sb link to link local directories in addition to github repos.

How to test

./lib/cli/bin/index.js link ../path/to/project --local

@nx-cloud
Copy link

nx-cloud bot commented May 16, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit c2f27f3. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@shilman shilman requested a review from tmeasday May 16, 2021 17:06
@shilman shilman mentioned this pull request May 16, 2021
Merged
tmeasday
tmeasday approved these changes May 17, 2021
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman merged commit 22fb0dc into next May 20, 2021
@shilman shilman deleted the feat/cli-link-local branch May 20, 2021 13:06
@zol
Copy link
Contributor

zol commented May 20, 2021

Fantastic @shilman ! Did you remember to add this to the new contributor docs too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

@tmeasday tmeasday tmeasday approved these changes

@stijnkoopal stijnkoopal Awaiting requested review from stijnkoopal

Assignees
No one assigned
Labels
cli feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shilman @zol @tmeasday @ndelangen