Addon-a11y: Highlight all elements correctly #14935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nx Cloud ReportCI ran the following commands for commit 25bbcae. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
yannbf
commented
May 14, 2021
| @@ -21,9 +21,12 @@ const highlight = (infos: HighlightInfo) => { | |||
| const id = HIGHLIGHT_STYLE_ID; | |||
| resetHighlight(); | |||
|
|
|||
| // Make sure there are no duplicated selectors | |||
| const elements = Array.from(new Set(infos.elements)); | |||
There was a problem hiding this comment.
I noticed that sometimes the elements array would be of size 20, but actually 10 of these selectors would be just duplicated, resulting in a longer stylesheet than necessary
shilman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Couldn't find an open issue for this
What I did
There was an extra curly bracket in the css for highlighting elements in the a11y addon, that resulted in a broken stylesheet.
Before:
After:
How to test
Build the addon and run any storybook, then toggle all elements to see the difference
Or check the chromatic build and test it there as well!
If your answer is yes to any of these, please make sure to include it in your PR.