Addon-docs: Remove all defaultValue eval-ing #14900
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Telescoping on #14899
Issue: #14579
What I did
argType.defaultValue
in any case.What I did not do
If
argType.defaultValue
is set, we continue to use it as the initial arg value (if the arg is otherwise unset).I think maybe we can clean up some test cases, @shilman we should probably walk through it together
How to test
Yes, lots of stories will be affected.