Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web-components: Support lit 2 with back-compat #14898

Merged
merged 8 commits into from
May 25, 2021

Commits on May 12, 2021

  1. Configuration menu
    Copy the full SHA
    bed2b65 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2021

  1. Configuration menu
    Copy the full SHA
    9d3d038 View commit details
    Browse the repository at this point in the history
  2. fix(web_components): keep .js extension to avoid issue with Webpack…

    … (related to export map?)
    gaetanmaisse committed May 24, 2021
    Configuration menu
    Copy the full SHA
    c42ba7c View commit details
    Browse the repository at this point in the history
  3. feat(cli): use @storybook/web_components when running sb init in a …

    …project with `lit` as dep
    gaetanmaisse committed May 24, 2021
    Configuration menu
    Copy the full SHA
    c0edc6e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0fe0852 View commit details
    Browse the repository at this point in the history
  5. feat(cli): do not add lit-html automatically when running sb init

    This SB generator is used in 3 cases and for each `lit-html` is already there so no need to reinstall it:
     - User's project has `lit-html` as dep -> ok nothing to do
     - User's project has `lit-element` as dep -> ok as `lit-html` is a dep of `lit-element`
     - User's project has `lit` as dep -> ok as `lit-html` is a dep of `lit-element`
    
    Note: SB WC will not work out of the box with Yarn in PnP mode as SB is doing import from `lit-html` directly.
    For now the recommended work around is to add `lit-html` as dep to satisfy SB WC peer dependency.
    We will be able to simplify/fix that easily when `lit-*` will be deprecated in favor of `lit`.
    gaetanmaisse committed May 24, 2021
    Configuration menu
    Copy the full SHA
    e83cdc6 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b9ec80a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    10e1fab View commit details
    Browse the repository at this point in the history