-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web-components: Support lit 2 with back-compat #14898
Merged
Merged
Commits on May 12, 2021
-
Configuration menu - View commit details
-
Copy full SHA for bed2b65 - Browse repository at this point
Copy the full SHA bed2b65View commit details
Commits on May 24, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 9d3d038 - Browse repository at this point
Copy the full SHA 9d3d038View commit details -
fix(web_components): keep
.js
extension to avoid issue with Webpack…… (related to export map?)
Configuration menu - View commit details
-
Copy full SHA for c42ba7c - Browse repository at this point
Copy the full SHA c42ba7cView commit details -
feat(cli): use @storybook/web_components when running
sb init
in a ……project with `lit` as dep
Configuration menu - View commit details
-
Copy full SHA for c0edc6e - Browse repository at this point
Copy the full SHA c0edc6eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fe0852 - Browse repository at this point
Copy the full SHA 0fe0852View commit details -
feat(cli): do not add
lit-html
automatically when runningsb init
This SB generator is used in 3 cases and for each `lit-html` is already there so no need to reinstall it: - User's project has `lit-html` as dep -> ok nothing to do - User's project has `lit-element` as dep -> ok as `lit-html` is a dep of `lit-element` - User's project has `lit` as dep -> ok as `lit-html` is a dep of `lit-element` Note: SB WC will not work out of the box with Yarn in PnP mode as SB is doing import from `lit-html` directly. For now the recommended work around is to add `lit-html` as dep to satisfy SB WC peer dependency. We will be able to simplify/fix that easily when `lit-*` will be deprecated in favor of `lit`.
Configuration menu - View commit details
-
Copy full SHA for e83cdc6 - Browse repository at this point
Copy the full SHA e83cdc6View commit details -
Configuration menu - View commit details
-
Copy full SHA for b9ec80a - Browse repository at this point
Copy the full SHA b9ec80aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 10e1fab - Browse repository at this point
Copy the full SHA 10e1fabView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.