-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hierarchySeparator to README #1445
Conversation
@joscha @igor-dv @ndelangen vote for |
Codecov Report
@@ Coverage Diff @@
## release/3.2 #1445 +/- ##
============================================
Coverage 20.36% 20.36%
============================================
Files 236 236
Lines 5136 5136
Branches 634 721 +87
============================================
Hits 1046 1046
+ Misses 3609 3546 -63
- Partials 481 544 +63
Continue to review full report at Codecov.
|
I am fine either way - I have a preference for |
At the current project I am working on, we use @ndelangen why not to expose this as a setting ? |
Having it configurable makes life more difficult for us in the long run. Imagine webpack inline-loaders-syntax being configurable, what a mess that would quickly turn into. I don't think it makes a whole lot of sense to make this configurable other than, in 1 documentation-page we advocate for another character. From what I hear everyone is actually OK with the I think we need a good why to increase the api-surface. How about this: I'll do a poll on twitter |
sounds good to me! |
One question that just occured to me - dots have been advocated a while: https://storybook.js.org/basics/writing-stories/#prefix-with-dots that's why we initially chose them. Has that changed? Is there special logic anywhere to do matching against dots in the search? EDIT: fuse.js seems to be fine with any separator... |
Is there a middle ground we can go for? maybe I can definitely see this getting messy with i18n, especially if things like the East Asian periods and Arabic reversed commas. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just go for it.
Please change default to /
changed to |
I'll add the default in code later today/tomorrow |
Merging and leaving @igor-dv for the code followup 👍 |
Add
hierarchySeparator
example.