Core: Make Storybook esbuild-compatible #14380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eirslett
requested review from
alexandrebodin,
alterx,
igor-dv,
leonrodenburg,
ndelangen,
shilman,
theinterned,
thomasbertet and
tmeasday
as code owners
eirslett
force-pushed
the
esbuild-compatible
branch
from
31e36e7 to
4b53a01
Compare
This would be a good fundament for adding Snowpack/Vite builder support. Currently, Storybook UI can be built by Webpack or tsc, but esbuild transpiles .ts file-by-file and therefore has some caveats: https://esbuild.github.io/content-types/#typescript-caveats This change adds isolatedModules: true to tsconfig.json, and fixes a few places in the Storybook source code. The result has been briefly tested with esbuild - with these changes, it's possible to build Storybook UI using Vite.
eirslett
force-pushed
the
esbuild-compatible
branch
from
4b53a01 to
f74a04a
Compare
shilman
changed the title
shilman
reviewed
Mar 29, 2021
|
|
||
| // Make it work with --isolatedModules, we need a dummy export | ||
| /* eslint-disable jest/no-export */ | ||
| export default {}; |
There was a problem hiding this comment.
why export default {}; here and export {}; above?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be a good fundament for adding Snowpack/Vite
builder support. Currently, Storybook UI can be built by
Webpack or tsc, but not esbuild. Esbuild transpiles .ts file-by-file
and therefore has some caveats:
https://esbuild.github.io/content-types/#typescript-caveats
What I did
This change adds isolatedModules: true to tsconfig.json,
and fixes a few places in the Storybook source code.
(Mostly
export type)The result has been briefly tested with esbuild - with
these changes, it's possible to build Storybook UI
using Vite.
How to test
I tested building it manually using Esbuild, but my setup is
quite cumbersome to replicate. At least I don't think this change
will break anything - if anything breaks, the automated test
suite should uncover it.