docs: add workaround for ts baseurl module resolution #14371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide method to alllow TypeScript modules to resolve when aliased with baseUrl in tsconfig Ref: #13184, #14087 Signed-off-by: Josh Habdas <[email protected]>
ghost
requested review from
ghost
commented
Mar 29, 2021
| @@ -1,61 +1,61 @@ | |||
| { | |||
| "@storybook/addon-a11y": "6.2.0-rc.9", | |||
There was a problem hiding this comment.
This change was somehow automated by tooling. Please let me know if I should yank it.
ghost
mentioned this pull request
|
Please note I haven't tested the docs locally so I'm not sure what the end result will look like. |
|
@ghost going to close this pull request in favor of #15865, as the documentation was polished and now includes your suggestion. Thank you for the time and effort you've put into this small but rather important pull request and help us and the rest of the community expand the documentation and address the said use case. We really appreciate it. Feel free to reach out to us if you spot issues with the documentation or any other issue with Storybook! Looking forward to your next contribution. Stay safe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide method to alllow TypeScript modules to resolve when aliased with
baseUrl in tsconfig
Ref: #13184, #14087
Signed-off-by: Josh Habdas [email protected]