-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Controls: Fix edge case in datetime control #14348
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabiseabra
requested review from
alexandrebodin,
alterx,
leonrodenburg,
ndelangen,
theinterned and
tmeasday
as code owners
March 26, 2021 11:26
shilman
changed the title
[fix] edge case in datetime type knob
Controls: Fix edge case in datetime control
Mar 29, 2021
ghengeveld
approved these changes
Mar 30, 2021
This was referenced Sep 20, 2023
Open
Open
Open
Open
This was referenced Nov 24, 2023
Open
This was referenced Mar 22, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced May 20, 2024
Open
This was referenced Sep 17, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #13771
What I did
Mutating a Date object with
setMonth
andsetDate
will validate and potentially adjust it by rolling into the next month if the resulting month has fewer days than the resulting day.I've modified the date change callback in each date-time component to apply changes in one step with
setFullYear
instead of separate steps for year/month/day.How to test
official-storybooks > Controls > Date > Basic
If your answer is yes to any of these, please make sure to include it in your PR.