Angular: Fix handling of line breaks with multiple selectors

[dexster]

Issue: #14079

What I did

Previous PR was faulty and missing some of the recommendations by @ThibaudAV. This commit includes them as well as extra checks for line breaks in multiple selectors.

How to test

Tests added for all scenarios

[ThibaudAV]

LGTM, Just a suggestion to try to improve code readability
You did well to add tests to increase confidence in these not very digest regex

[ThibaudAV]

I find the original one not very readable and I propose another solution that uses a reduce. what do you think ?

  const templateReplacers: [
    string | RegExp,
    string | ((substring: string, ...args: any[]) => string)
  ][] = [
    [/(^\..+)/, 'div$1'],
    [/(^\[.+?])/, 'div$1'],
    [/([\w[\]]+)(\s*,[\w\s-[\],]+)+/, `$1`],
    [/#([\w-]+)/, ` id="$1"`],
    [/((\.[\w-]+)+)/, (_, c) => ` class="${c.split`.`.join` `.trim()}"`],
    [/(\[.+?])/g, (_, a) => ` ${a.slice(1, -1)}`],
    [/([\S]+)(.*)/, `<$1$2${inputs}${outputs}>${innerTemplate}</$1>`],
  ];

  return templateReplacers.reduce(
    (prevSelector, [searchValue, replacer]) => prevSelector.replace(searchValue, replacer as any),
    selector
  );

[dexster]

Yeah. reduce expresses the intent better than map. Let me do this

[ThibaudAV]

🤔 I don't understand this change. Is it necessary?

[dexster]

I don't understand this either 😄 I only changed the template file and tests. I think yarn test -u might be the culprit. I'll try remove this file with my next commit

[dexster]

Please assist with the latest commit. I tried to revert this file hoping it would be removed from the PR but the new commit shows the deleted lines. Is it as simple as using "Delete file" from the menu in "Files changed" to remove it from the PR?

[dexster]

Nevermind. I see it's been removed from Files changed

[dexster]

This can be merged like this but I think it would be better to remove this file from the PR.

[ThibaudAV]

LGTM ;)

[dexster]

@shilman Do you think this could be merged soon?

[shilman]

@dexster yes, possibly today. we've been in a merge freeze while the latest release is stabilizing, but i'm planning on lifting that and commencing 6.3 alphas. after it's released and tested on alpha, i can patch it back to 6.2.x if @ThibaudAV gives the thumbs up.

[mhulse]

I'm new to SB, but I think the regex is not handling attribute selectors and class selectors, like:

	selector: "button[foo],"
	        + ".button[foo],"
	        + "button[baz],"
	        + ".button[baz],"
	        + "button[bar],"
	        + ".button[bar],"
	        + "button[blah],"
	        + ".button[blah]"

When I remove the classes, it works. When I do a single class selector, it works. etc.

EDIT: Bug ticket created: #15975