Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angular: Create actions for Outputs by default #14299

Merged
merged 2 commits into from
Apr 15, 2021
Merged

Angular: Create actions for Outputs by default #14299

merged 2 commits into from
Apr 15, 2021

Conversation

Jakob-em
Copy link
Contributor

Relates to: #14285

What I did

Add actions for angular outputs that are detected via compodoc, so that users don't have to specify those actions manually.

How to test

  • Is this testable with Jest or Chromatic screenshots?
    I adjusted the existing compodoc -> argType test
  • Does this need a new example in the kitchen sink apps?
    I updated one of the stories in the angular-example project to make this manually testable
  • Does this need an update to the documentation?
    I don't think so, but if you wish to include it I can add a small section about the new behaviour

shilman
shilman approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the improvement @Jakob-em! Marked as do not merge since we're already in 6.2-rc, and we'll need to wait until 6.3-alpha to get this in

@Jakob-em
Copy link
Contributor Author

Hi @shilman, now that 6.3-alpha has started, do you think we can get this merged?

@shilman
Copy link
Member

shilman commented Apr 14, 2021

Yepp

@shilman shilman changed the title Create actions for angular Outputs by default Angular: Create actions for Outputs by default Apr 15, 2021
@shilman shilman added the run e2e extended test suite Run the e2e extended test suite in CircleCI workflows label Apr 15, 2021
@shilman shilman merged commit 4203b79 into storybookjs:next Apr 15, 2021
@shilman shilman mentioned this pull request May 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@alterx alterx Awaiting requested review from alterx

@igor-dv igor-dv Awaiting requested review from igor-dv

Assignees
No one assigned
Labels
addon: actions angular feature request run e2e extended test suite Run the e2e extended test suite in CircleCI workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jakob-em @shilman