Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebComponents: Fix types and improve CLI detection #14258

Merged
merged 4 commits into from
Mar 17, 2021
Merged

WebComponents: Fix types and improve CLI detection #14258

merged 4 commits into from
Mar 17, 2021

Conversation

gaetanmaisse
Copy link
Member

Related to #12395 (comment)

What I did

  • use types from lit-html instead of lit-element to avoid dependency issues for lit-html-only users
  • remove unneeded lit-html dep and keep only lit-element in config used to run WC E2E test
  • add detection of bare lit-html projects (and not only lit-element ones) in SB CLI

How to test

  • CI should be 🟢
  • Using this branch locally with yarn link should allow you to make SB runs in a bare lit-html project, and sb init should properly detect a WC setup.

@gaetanmaisse gaetanmaisse added maintenance User-facing maintenance tasks web-components labels Mar 17, 2021
@gaetanmaisse gaetanmaisse mentioned this pull request Mar 17, 2021
Merged
@gaetanmaisse gaetanmaisse marked this pull request as ready for review March 17, 2021 11:11
@gaetanmaisse gaetanmaisse added the run e2e extended test suite Run the e2e extended test suite in CircleCI workflows label Mar 17, 2021
ndelangen
ndelangen reviewed Mar 17, 2021
View reviewed changes
lib/cli/src/detect.test.ts
files: {
'package.json': {
dependencies: {
'lit-html': '1.0.0',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be an exact dep?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just for the test fixture ;) any version is ok

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@ndelangen ndelangen merged commit a4e981c into next Mar 17, 2021
@ndelangen ndelangen deleted the fix/update-wc-types branch March 17, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

@igor-dv igor-dv Awaiting requested review from igor-dv

@shilman shilman Awaiting requested review from shilman

@stijnkoopal stijnkoopal Awaiting requested review from stijnkoopal

Assignees
No one assigned
Labels
maintenance User-facing maintenance tasks run e2e extended test suite Run the e2e extended test suite in CircleCI workflows web-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaetanmaisse @ndelangen